Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the close method so that underlying files aggregated by NcML are closed #44

Merged
merged 5 commits into from
May 23, 2023
Merged

Set the close method so that underlying files aggregated by NcML are closed #44

merged 5 commits into from
May 23, 2023

Conversation

huard
Copy link
Collaborator

@huard huard commented May 23, 2023 •
edited
Loading

  • Include documentation when adding new features.
  • Include new tests or update existing tests when applicable.

Set the close method to close all underlying opened files aggregated by NcML, similar to what open_mfdataset does.

Fixes #41

@huard huard requested a review from aulemahal May 23, 2023 19:57
@huard huard changed the title Set the close function so that underlying files aggregated by NcML are closed Set the close method so that underlying files aggregated by NcML are closed May 23, 2023
aulemahal
aulemahal approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understand file handling in xarray/netcdf, this looks good!

A small suggestion about the psutil requirement though.

requirements.txt Show resolved Hide resolved
@huard huard merged commit e329b96 into main May 23, 2023
@huard huard deleted the fix-41 branch May 23, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aulemahal aulemahal aulemahal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set close method to close all underlying files
2 participants
@huard @aulemahal