Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests #10

Closed
wants to merge 5 commits into from
Closed

Add tests #10

wants to merge 5 commits into from

Conversation

willirath
Copy link
Contributor

@willirath willirath commented Jun 29, 2020 •
edited
Loading

Closes #3.

  • test the XoakAccessor index property
  • test non-transformed coordinate values (perhaps with other data than geo coordinates)
  • test NN lookup tolerance
  • check that the order of coordinate labels in the returned selection is preserved (I checked this locally simply by inspecting the results and it works)
  • shallow test for the DataArray.xoak accessor

@benbovy benbovy mentioned this pull request Oct 29, 2020
Merged
3 tasks
@benbovy
Copy link
Member

benbovy commented Dec 17, 2020

Closed in #28 and #30

@benbovy benbovy closed this Dec 17, 2020
@benbovy benbovy mentioned this pull request Dec 17, 2020
Closed
5 tasks
@benbovy benbovy deleted the add-tests branch August 4, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willirath @benbovy