Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PEM certificates as well as files #59

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Support PEM certificates as well as files #59

merged 3 commits into from
Aug 5, 2024

Conversation

eminano
Copy link
Collaborator

@eminano eminano commented Aug 5, 2024

Expand support of TLS library to accept a certificate file or the certificate PEM content directly.

pkg/tls/tls.go Outdated Show resolved Hide resolved
ryanslade
ryanslade previously approved these changes Aug 5, 2024
Copy link

@ryanslade ryanslade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. It is a bit confusing to overload the config to be a path or cert content though. Is it possible to update the config itself to have different properties and it's expected that the client only provides one or the other?

pkg/tls/tls.go Outdated Show resolved Hide resolved
Copy link

@ryanslade ryanslade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a deal breaker, but might be worth adding some tests?

@eminano eminano merged commit 7418324 into main Aug 5, 2024
5 checks passed
@eminano eminano deleted the update-tls-lib branch August 5, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants