Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPI: add test extension #40

Merged
merged 4 commits into from
Apr 10, 2024
Merged

SPI: add test extension #40

merged 4 commits into from
Apr 10, 2024

Conversation

urso
Copy link
Collaborator

@urso urso commented Apr 9, 2024

Depends on #37, #38, #39

Fix import path in SPI module.

Add SPI testing extension to test suite to ensure SPI functioning correctly.

Copy link
Member

@tsg tsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, I'll follow up with README updates to add it to the table and such. I think we can also call the SPI support complete now in the status?

@urso
Copy link
Collaborator Author

urso commented Apr 10, 2024

I think we can also call the SPI support complete now in the status?

I still have some improvements for SPI support in mind. But these imrovements could be placed on top of the current APIs.

There are still a few things in SPI that we do not cover yet (or have example code for). E.g. cursor support, prepared statements, working with tuples. Maybe in we split SPI support in categories in the readme to highlight what is supported and what not.

@urso urso merged commit 2ac1b1b into xataio:main Apr 10, 2024
1 check passed
@urso urso deleted the spi-testing branch April 10, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants