fix: added lint check

xavidop · Dec 23, 2022 · 776a23f · 776a23f
1 parent 1ec9fd2
commit 776a23f
Show file tree

Hide file tree

Showing 9 changed files with 52 additions and 12 deletions.
diff --git a/.github/workflows/lint.yaml b/.github/workflows/lint.yaml
@@ -0,0 +1,28 @@
+name: golangci-lint
+on:
+  push:
+    tags:
+      - v*
+    branches:
+      - master
+  pull_request:
+permissions:
+  contents: read
+
+jobs:
+  golangci:
+    permissions:
+      contents: read  # for actions/checkout to fetch code
+      pull-requests: read  # for golangci/golangci-lint-action to fetch pull requests
+    name: lint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/setup-go@v3
+        with:
+          go-version: 1.19
+      - uses: actions/checkout@v3
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v3
+        with:
+          skip-go-installation: true
+          args: --timeout=5m
diff --git a/.github/workflows/master.yml b/.github/workflows/master.yml
@@ -12,12 +12,12 @@ jobs:
 
     steps:
       - name: Check out code into the Go module directory
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
         with:
           fetch-depth: 0 # See: https://goreleaser.com/ci/actions/
 
       - name: Set up Go 1.19
-        uses: actions/setup-go@v2
+        uses: actions/setup-go@v3
         with:
           go-version: 1.19
         id: go

diff --git a/cmd/agent/agent.go b/cmd/agent/agent.go
@@ -13,7 +13,9 @@ var agentCmd = &cobra.Command{
 	Aliases: []string{"agent", "a"},
 	Short:   "Actions on agent commands",
 	Run: func(cmd *cobra.Command, args []string) {
-		cmd.Help()
+		if err := cmd.Help(); err != nil {
+			os.Exit(1)
+		}
 		os.Exit(0)
 	},
 	PersistentPreRun: func(cmd *cobra.Command, args []string) {

diff --git a/cmd/cicd/cicd.go b/cmd/cicd/cicd.go
@@ -13,7 +13,9 @@ var cicdCmd = &cobra.Command{
 	Aliases: []string{"cicd", "ci", "cd"},
 	Short:   "Actions on CICD testings",
 	Run: func(cmd *cobra.Command, args []string) {
-		cmd.Help()
+		if err := cmd.Help(); err != nil {
+			os.Exit(1)
+		}
 		os.Exit(0)
 	},
 	PersistentPreRun: func(cmd *cobra.Command, args []string) {

diff --git a/cmd/profilenlu/profilenlu.go b/cmd/profilenlu/profilenlu.go
@@ -13,7 +13,9 @@ var profilenluCmd = &cobra.Command{
 	Aliases: []string{"test", "t", "tests"},
 	Short:   "Actions on testing",
 	Run: func(cmd *cobra.Command, args []string) {
-		cmd.Help()
+		if err := cmd.Help(); err != nil {
+			os.Exit(1)
+		}
 		os.Exit(0)
 	},
 	PersistentPreRun: func(cmd *cobra.Command, args []string) {

diff --git a/cmd/root.go b/cmd/root.go
@@ -28,7 +28,9 @@ You can find the documentation at https://github.com/xavidop/dialogflow-cx-cli.
 Please file all bug reports on Github at https://github.com/xavidop/dialogflow-cx-cli/issues.`,
 	Run: func(cmd *cobra.Command, args []string) {
 		if len(args) == 0 {
-			cmd.Help()
+			if err := cmd.Help(); err != nil {
+				os.Exit(1)
+			}
 			os.Exit(0)
 		}
 	},

diff --git a/cmd/stt/stt.go b/cmd/stt/stt.go
@@ -13,7 +13,9 @@ var sttCmd = &cobra.Command{
 	Aliases: []string{"stt", "speech-to-text"},
 	Short:   "Actions on speech-to-text commands",
 	Run: func(cmd *cobra.Command, args []string) {
-		cmd.Help()
+		if err := cmd.Help(); err != nil {
+			os.Exit(1)
+		}
 		os.Exit(0)
 	},
 	PersistentPreRun: func(cmd *cobra.Command, args []string) {

diff --git a/cmd/tts/tts.go b/cmd/tts/tts.go
@@ -13,7 +13,9 @@ var ttsCmd = &cobra.Command{
 	Aliases: []string{"tts", "text-to-speech"},
 	Short:   "Actions on text-to-speech commands",
 	Run: func(cmd *cobra.Command, args []string) {
-		cmd.Help()
+		if err := cmd.Help(); err != nil {
+			os.Exit(1)
+		}
 		os.Exit(0)
 	},
 	PersistentPreRun: func(cmd *cobra.Command, args []string) {

diff --git a/pkg/cx/sessionsclient.go b/pkg/cx/sessionsclient.go
@@ -38,7 +38,7 @@ func DetectIntentFromText(sessionClient *cx.SessionsClient, agent *cxpb.Agent, l
 		LanguageCode: localeId,
 	}
 
-	response, err := DetectIntent(sessionClient, agent, queryInput)
+	response, err := DetectIntent(sessionClient, agent, &queryInput)
 	if err != nil {
 		return nil, err
 	}
@@ -70,20 +70,20 @@ func DetectIntentFromAudio(sessionClient *cx.SessionsClient, agent *cxpb.Agent,
 		LanguageCode: localeId,
 	}
 
-	response, err := DetectIntent(sessionClient, agent, queryInput)
+	response, err := DetectIntent(sessionClient, agent, &queryInput)
 	if err != nil {
 		return nil, err
 	}
 
 	return response, nil
 }
 
-func DetectIntent(sessionClient *cx.SessionsClient, agent *cxpb.Agent, queryinput cxpb.QueryInput) (*cxpb.DetectIntentResponse, error) {
+func DetectIntent(sessionClient *cx.SessionsClient, agent *cxpb.Agent, queryinput *cxpb.QueryInput) (*cxpb.DetectIntentResponse, error) {
 	ctx := context.Background()
 
 	sessionPath := fmt.Sprintf("%s/sessions/%s", agent.GetName(), uuid.NewString())
 
-	request := cxpb.DetectIntentRequest{Session: sessionPath, QueryInput: &queryinput}
+	request := cxpb.DetectIntentRequest{Session: sessionPath, QueryInput: queryinput}
 
 	response, err := sessionClient.DetectIntent(ctx, &request)
 	if err != nil {