Skip to content

Commit

Permalink
Add comment explaining why patch is still needed (spack#3054)
Browse files Browse the repository at this point in the history
[The fix](golang/go#17986) for the small buglet addressed by `misc-cgo-testcshared.patch` has been merged into the tree a while back.  I was surprised to see that it wasn't in 1.7.5 and did a bit of digging.  It is *has not* been merged into the 1.7 branch but it *has* been merged into 1.8 (and therefor the patch will no longer be necessary).

Figured I'd document my digging for the next person to come along.
  • Loading branch information
hartzell authored and Xavier Iago Andrade-valencia committed Jun 16, 2017
1 parent b72120e commit 63cd470
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions var/spack/repos/builtin/packages/go/package.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ class Go(Package):
patch('time_test.patch', when='@1.6.4:1.7.4')

# https://github.com/golang/go/issues/17986
# The fix for this issue has been merged into the 1.8 tree.
patch('misc-cgo-testcshared.patch', level=0, when='@1.6.4:1.7.5')

# NOTE: Older versions of Go attempt to download external files that have
Expand Down

0 comments on commit 63cd470

Please sign in to comment.