Show brief comments (updated patches) #385
Conversation
Our complete flag handling has been completely broken. In ancient times, we had to calculate the bits in the complete flags ourselves, but nowadays cindex.py has a nice interface based on named parameters. However, we have still been passing the ancient complete flags to this interface, which meant we always set complete_macros=True and all other flags to false independently of the actual complete options set. This patch fixes this. It ensures that we pass complete flags as named parameters which makes the individual flags work again. Based on patches from Dmitri Gribenko <gribozavr@gmail.com>
We add a new option g:clang_include_brief_comments which includes brief comments in the completion results This change also introduces routines to translate python to vim data structures. In an earlier review I saw performance regressions, but I could not reproduce them before. I also did not include further optimizing patches as they caused problems in the presence of '\n'. Based on patches from Dmitri Gribenko <gribozavr@gmail.com>
|
This is a reworked version of #199 |
|
Can you add a comment on toVimRepr to state that pyeval can be used instead? As far as I remember this was added "recently" and certain popular distribution didn't package a newer enough vim. Rest looks great! |
|
On 03/08/2014 04:43 AM, Xavier Deguillard wrote:
I don't get your comment. Something like: "We can not currently use pyeval, as it is not yet available in So are you saying pyeval would always do the right conversions? Tobias |
|
Yes, I believe pyeval can be used instead of the toVimRepr function yes, and should also be much faster. |
No description provided.