Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

factor out internal identityFn to utils #431

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

sisp
Copy link
Contributor

@sisp sisp commented Mar 11, 2022

Just a minor refactoring. identityFn was defined in several places, so I factored it out into utils/index.ts. One type assertion is necessary in getSnapshot(...) to make it work though.

@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #431 (eb4e569) into master (a7bd0c2) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #431      +/-   ##
==========================================
- Coverage   90.93%   90.93%   -0.01%     
==========================================
  Files         179      179              
  Lines        6388     6387       -1     
  Branches     1157     1157              
==========================================
- Hits         5809     5808       -1     
  Misses        542      542              
  Partials       37       37              
Impacted Files Coverage Δ
src/snapshot/getSnapshot.ts 95.23% <0.00%> (-0.22%) ⬇️
src/types/primitiveBased/primitives.ts 98.00% <0.00%> (-0.04%) ⬇️
src/types/utility/unchecked.ts 88.88% <0.00%> (ø)
src/utils/index.ts 82.69% <0.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7bd0c2...eb4e569. Read the comment docs.

@xaviergonz xaviergonz merged commit 0bc6a0d into xaviergonz:master Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants