Zip in channel #11
Closed
Zip in channel #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets people read files that aren't necessarily on the file system (for example, files being streamed over the network, or files sent through a pipe).
|
Actually, this probably isn't that useful since you can't seek a pipe or socket :\ |
|
Thanks for the proposal. As you wrote it's probably not enough for what you want to achieve. A case could be made for refactoring this library on top of abstract I/O channels that support both files and in-memory data (strings and bytes, but also Buffer.t and bigarrays, see #7). That's significant work, though. |
|
Hmm yeah I might look into that at some point :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us read zip files that aren't on the file system.
In particular, I want to be able to unzip files that I'm already holding in memory, and pushing them through a pipe is better than having to write to a temp file. Ideally I wouldn't need an
in_channelat all, but taking a string as an input would be a lot more changes.