Allow web serving of user files #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mod allows users to serve their own files (Images) without the need to setup a separate web server. It creates a new endpoint myfiles, e.g. "http://192.168.1.1:9999/myfiles/images/5.jpg" will serve a file called 5.jpg from an images sub-directory in the new myfiles directory
In the case of images, XBVR will still cache them in the imageproxy. Essentially, XBVR will serve images to itself.
FYI, the change is built on release 0.4.15, it has then been merged with #1449 "Configuration Options" to allow the location of the myFiles directory to be moved separate from the default XBVR location if required. If #1449 does not get implemented, it should be easy to remove the last commits remove the #1448 functionality.