Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Decrypter] undefine LOCLICENSE so .challenge, .init etc files are not written to disk #770

Merged
merged 1 commit into from
Sep 29, 2021
Merged

[Decrypter] undefine LOCLICENSE so .challenge, .init etc files are not written to disk #770

merged 1 commit into from
Sep 29, 2021

Conversation

matthuisman
Copy link
Contributor

@matthuisman matthuisman commented Aug 1, 2021

not sure the need for these 4 files that are written.
probably for debugging back in the day.

IMO we shouldn't be writing to disc anymore than needed.
Devices like RPI SD cards have certain amount of writes blah.

It may also increase playback speed of WV content very slightly
More so on devices with slow write speeds (mechanical drive etc)

The "widevine" folder that is created I think is still needed for when persistent storage is enabled

@matthuisman matthuisman changed the title [Decrypter] ndefine LOCLICENSE so .challenge .init files are not written to disk [Decrypter] Undefine LOCLICENSE so .challenge, .init etc files are not written to disk Aug 1, 2021
@AlwinEsch AlwinEsch changed the base branch from Matrix to Nexus September 14, 2021 14:33
@glennguy
Copy link
Contributor

These files can be useful in debugging issues with users, like with #812
Maybe it might be worth thinking about instead putting this behind a IA setting?

@matthuisman
Copy link
Contributor Author

matthuisman commented Sep 28, 2021

be good if we could detect kodis log level and only enable for debug level

Also, i think thats the 1st time i've seen these requested...
Pretty rare to need them.
Even when we get sent them, i really dont see them helping :(

@glennguy
Copy link
Contributor

I don't think we can detect the log level...
I've seen peak3d ask for them once before as part of debugging.
How about we disable for now and if needed in the future we can put behind an expert setting?

wvdecrypter/wvdecrypter.cpp Show resolved Hide resolved
wvdecrypter/wvdecrypter_android_jni.cpp Outdated Show resolved Hide resolved
@matthuisman matthuisman changed the title [Decrypter] Undefine LOCLICENSE so .challenge, .init etc files are not written to disk [Decrypter] default LOCLICENSE to 0 so .challenge, .init etc files are not written to disk Sep 28, 2021
@matthuisman matthuisman changed the title [Decrypter] default LOCLICENSE to 0 so .challenge, .init etc files are not written to disk [Decrypter] undefine LOCLICENSE so .challenge, .init etc files are not written to disk Sep 28, 2021
@matthuisman
Copy link
Contributor Author

ready

@glennguy glennguy requested a review from phunkyfish September 28, 2021 23:13
@spacys
Copy link

spacys commented Jan 5, 2023

Maybe it might be worth thinking about instead putting this behind a IA setting?

Good idea, I would prefer this option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants