Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[script.module.cache] 1.0.3 #1125

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

FraserChapman
Copy link

Description

Just updated the python version to 2.25.0

see: #1115

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [script.foo.bar] 1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practise but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.

@FraserChapman FraserChapman mentioned this pull request Aug 18, 2019
3 tasks
@TravisBuddy
Copy link

Travis Buddy

Hey Fraser,
please review the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

Expand here
INFO: Checking add-on script.module.cache
INFO: Created by fraser
INFO: Addon id matches folder name
ERROR: script.module.cache addon already exists with version: 1.0.2 in krypton branch
INFO: Valid XML file found
INFO: Reverse dependencies: plugin.video.bfi, plugin.video.bp, plugin.video.dw, plugin.video.eafa, plugin.video.eye, plugin.video.loc, plugin.video.mia, plugin.video.nfpf, plugin.video.ng, plugin.video.ntsv, plugin.video.pa (11)
INFO: You might want to add a icon
INFO: Module skipping whitelist
ERROR: We found 1 problems and 0 warnings, please check the logfile.

script.module.cache/.gitignore Outdated Show resolved Hide resolved
script.module.cache/addon.xml Outdated Show resolved Hide resolved
@FraserChapman FraserChapman force-pushed the script.module.cache_krypton branch from 6108e2a to a8c5847 Compare August 19, 2019 08:58
@TravisBuddy
Copy link

Travis Buddy

Hey Fraser,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@Rechi Rechi merged commit fdb1d49 into xbmc:krypton Aug 19, 2019
@FraserChapman FraserChapman deleted the script.module.cache_krypton branch August 19, 2019 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants