APP_RENDER_SYSTEM is not being passed to ProjectM #87
Comments
fuzzard
pushed a commit
to fuzzard/xbmc
that referenced
this issue
Aug 13, 2022
Allows a user to pass through cmake arguments to all addon dependencies that are built Be aware, this is a global addition, and will be passed through to all addons built. Usage: -DADDON_EXTRA_ARGS="-Ddefine1=1 -Ddefine2=2" The arguments will be passed through as a list (ie -Ddefine1=1;-Ddefine2=2) to all addon dependencies built, and will be accessible via their CMakelists.txt files an example is with visualization.projectm. If a user wishes to set -DAPP_RENDER_SYSTEM=gles for the projectm dependency to build projectm as gles compatible. Currently this can be done with a toolchain file, but a user cant set -DAPP_RENDER_SYSTEM=gles as art of their cmake stanza to build the addon, as dependencies are passed through filtered lists, of which APP_RENDER_SYSTEM isnt specifically passed through. xbmc/visualization.projectm#87 This solution provides a more generic way to pass through arguments to cmake dependencies without us explicitly handling each option in HandleDepends.cmake
13 tasks
|
Have made a PR that will support this situation usage would be Doubtful id backport this to v19, so if you wish to do this for v19, it can be done by supplying a toolchain file using -DCMAKE_TOOLCHAIN_FILE=path/to/toolchain/file.cmake with a contents of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I try to build this addon with:
cmake -DADDONS_TO_BUILD=visualization.projectm -DADDON_SRC_PREFIX=../.. -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/usr/local -DAPP_RENDER_SYSTEM=gles ../../xbmc19/cmake/addonsBut for some reason this isn't passed on to this:
visualization.projectm/depends/common/projectm/CMakeLists.txt
Line 4 in 2ab8803
So I had to remove the if statement in order to successfully build and run it on my ODroid board.
The text was updated successfully, but these errors were encountered: