Validate report period against month_day so that we do not get a key error in get_dates() #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtauriello
force-pushed
the
main
branch
6 times, most recently
from
00390f4 to
dfd4b63
Compare
davidtauriello
force-pushed
the
main
branch
15 times, most recently
from
1a15740 to
01590c4
Compare
davidtauriello
force-pushed
the
main
branch
2 times, most recently
from
1486848 to
9c7fed3
Compare
davidtauriello
force-pushed
the
main
branch
3 times, most recently
from
901214e to
a563f8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When a value for report_period does not conform to the
Q1,Q2,Q3orQ4, then a key error can be thrown in the return ofget_dates(). This PR rearranges report_year and report_period so that report_period can verify that the value is in the above list of values.Testing:
Create a document that has a report_period set as something random like
Quarter 1. Run it against master and notice that you get a key error. Run the same doc against this branch and you will get a nicely formatted FERCRenderException that explains what the actual issue is.@campbellpryde
@davidtauriello