Pre-parse output attribute declarations #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When declaring new output attributes using the 'output-attribute' keyword, XULE needs to incorporate these new keywords into its grammar before it can parse the remaining file. This is particularly necessary when using XINCE because all the attributes it needs declared.
davidtauriello
force-pushed
the
main
branch
3 times, most recently
from
901214e to
a563f8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When declaring new output attributes using the 'output-attribute' keyword, XULE needs to incorporate these new keywords into its grammar before it can parse the remaining file. Otherwise, it crashes when seeing a "new" keyword. This is particularly necessary when using XINCE because all the attributes it needs declared. Also, I copied over these edits directly from my site-packages installation so I might miss something just let me know.