Automatic fetching of latest xbs-api and services + npm build error fix #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this @steccas, looks great! I've very little free time at the moment but will review this soon. |
|
Thanks @nero120, please bear in mind that the fact that the dockerfile grabs the latest xbs version has some implications. So maybe we can consider some CI/CD that keeps the image on the HUB updated, like running a build on a new release of xbs or maybe just scheduling. (like I did in my repo with github actions) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I tought to send this PR because I noted the probles that I've reported with issues #21 and #22 .
The build is now smooth and clean and keeping the xbs api updated is now easier.