LineLogger NewLineBuf timestamp format

[mattaezell]

https://github.com/chenglch/goconserver/blob/4415be43710a8eafaa940300b79d4fe4ed8af92b/console/pipeline/logger.go#L26

Many systems use milliseconds (elasticsearch), microseconds, or nanoseconds; but 5 zeros is very uncommon. Consider moving this to 3 or 6. Better yet, allow the format to be customized in the config file.

[chenglch]

@mattaezell , A new build has been uploaded to fix these issues, you could download it from https://github.com/chenglch/goconserver/releases/tag/v0.2.1 .

A new option has been added to help customize the time precision, the default value is microsecond.

console:
  # log the timestamp.
  log_timestamp: true
  # time precison for tcp or udp logger, precison for file logger is always second.
  # Valid options: second, millisecond, microsecond, nanosecond
  time_precision: microsecond

[mattaezell]

Confirmed.
2018-02-01 20:04:22.777 h41n02 hello
Thanks!

[mattaezell]

Sorry: now that I've had a bit more time to look into this I might need to request a slightly different format. It seems that many programs use ISO 8601 with a T character instead of a space between the date and time. Times also usually include a timezone (Z for UTC or +05:00 for another zone).

We plan to push consoles directly into ElasticSearch and evaluate them using sec

ElasticSearch uses strict_date_optional_time||epoch_millis by default
joda-time is the definition that ElasticSearch uses

[robin2008]

@mattaezell Do you mean ISO 8601 format is required for timestamp in log?

[mattaezell]

@robin2008 At this stage, I'm not sure I could list it as a hard "requirement" (since I can convert formats), but it would certainly make integration with other products easier.

[chenglch]

@mattaezell , thanks for your advice, a new build to fix this has been uploaded inside the release link https://github.com/chenglch/goconserver/releases/tag/v0.2.1

[mattaezell]

Unfortunately I don't think the current format is correct. I'm seeing
2018-02-02T08:34:59-0500.439 h41n04 [goconserver connected]
where the fraction of the second is attached to the timezone instead of the second. It should look like:
2018-02-02T09:42:39.060-05:00 h41n04 [goconserver connected]

Please consider merging #21

Thanks!

[chenglch]

Sorry, I'm not familiar with the time format. The latest build including your patch has been uploaded.
Thanks.

[mattaezell]

Thanks @chenglch. Looks good!

[neo954]

Verified with goconserver-0.2.1-snap201803020124.ppc64le. I will close this one.

if still have question against this issue, please don't hesitate to reopen this issue.