Backport support for NFSv4 only env #49
Merged
+188
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: xapi-project#617 Signed-off-by: Benjamin Reis <benjamin.reis@vates.tech>
|
As this backports 2 separate PRs, I think we should create 2 commits and not squash them. |
stormi
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
LGTM but that's a lot of changes, so I'll need @Wescoeur's and @benjamreis' "there's no regression here" stamps.
Wescoeur
approved these changes
Dec 19, 2023
See: xapi-project#655 Signed-off-by: Benjamin Reis <benjamin.reis@vates.tech>
benjamreis
force-pushed
the
2.30.8-8.2-nfsv4
branch
from
4671cfe to
e121b78
Compare
benjamreis
added a commit
to xcp-ng-rpms/sm
that referenced
this pull request
Dec 19, 2023
See: xcp-ng/sm#49 Signed-off-by: BenjiReis <benjamin.reis@vates.fr>
Wescoeur
pushed a commit
to xcp-ng-rpms/sm
that referenced
this pull request
Dec 21, 2023
See: xcp-ng/sm#49 Signed-off-by: BenjiReis <benjamin.reis@vates.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: xapi-project#617
And: xapi-project#655