Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracking issue for necessity of cargo +nightly tarpaulin #150

Closed
softprops opened this issue Oct 1, 2018 · 10 comments
Closed

tracking issue for necessity of cargo +nightly tarpaulin #150

softprops opened this issue Oct 1, 2018 · 10 comments

Comments

@softprops
Copy link

something that keeps popping up when I get pulls in my crates that use tarpaulin is the newish dependency on +nightly. I'm now familiar with this as a work around I wanted to open an issue that can maybe use as a tracking issue to get notified when this is no longer necessary.

@softprops softprops changed the title tracking issue for necessity cargo +nightly tarpaulin tracking issue for necessity of cargo +nightly tarpaulin Oct 1, 2018
@djc
Copy link

djc commented Oct 2, 2018

Also it would be nice if the README was updated to correct the example Travis config.

xd009642 added a commit that referenced this issue Oct 2, 2018
@xd009642
Copy link
Owner

xd009642 commented Oct 2, 2018

@djc done 👍

Also, I'm watching this thread myself but this issue on the rust compiler is the blocker for tarpaulin on stable rust-lang/rust#54725 once this is solved and in stable proc-macro and syn can be updated and tarpaulin can come back to stable

@softprops
Copy link
Author

Awesome thanks for being in top of this @xd009642 and thanks for your hard work on filling this gap in the rust ecosystem.

@djc
Copy link

djc commented Oct 2, 2018

@xd009642 much thanks! Could have saved me a few iterations when I tried to get it to work. 😁

softprops added a commit to softprops/serverless-crowbar that referenced this issue Oct 2, 2018
@softprops
Copy link
Author

https://blog.rust-lang.org/2018/10/25/Rust-1.30.0.html looks like 1.30 is out with more macro stabilizations. Does that move this gh issue forward?

@xd009642
Copy link
Owner

Doesn't seem to all the Span methods are still marked as unstable

@softprops
Copy link
Author

doh :/

@xd009642
Copy link
Owner

So brief update. I've still got publish-lockfile in the Cargo.toml necessitating nightly. However, with that commented out tarpaulin can now run and pass on stable. There's a change to the stable dockerfile courtesy of @AnderEnder so now you can get tarpaulin on stable via docker.

Proc-macro2 probably still has the issue where it only works with the version of rustc it was compiled with. This is what necessitated publish-lockfile but given the rate stable updates I don't see this having a big effect on stable users.

@softprops
Copy link
Author

awesome Ill give this a shot

@xd009642
Copy link
Owner

So due to some changes in source analysis and some stablisations in procedural macros you no longer need nightly to run tarpaulin so I'm closing this issue 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants