-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README updates for Docker #144
base: main
Are you sure you want to change the base?
Conversation
Information on getting Visual Code + PHP Debug extension working with PHP running in Docker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does the diff replace the whole README? Did you change line endings or something like that?
Not on purpose, but very possibly. Let me see if I can de-fubar it... |
@jasonterando Thanks for the updates here. Even though the PR hasn't been accepted your steps for Windows XDEBUG configuration worked perfectly for me. |
@sgwatgit - awesome, glad to help! |
This also needs to be updated to reflect the changes for the new pathmappings setting. |
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
=======================================
Coverage 80.18% 80.18%
=======================================
Files 2 2
Lines 111 111
Branches 22 22
=======================================
Hits 89 89
Misses 14 14
Partials 8 8 Continue to review full report at Codecov.
|
I didn't realize anybody was still looking at this. I've updated to include pathMappings and the built-in Docker localhost aliases. |
@jasonterando I think you committed a bad merge |
Did a re-merge with master and the CI/CD checks seem to be happier |
@jasonterando please look at the file on your branch. It was messed up: https://github.com/jasonterando/vscode-php-debug/blob/c65725e1bd5fcea4034c12776f967af2ccb312e3/README.md |
Too bad this isn't merged yet, very helpful additional info! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The README is still messed up unfortunately, it duplicates a majority of the content
Information on getting Visual Code + PHP Debug extension working with PHP running in Docker. It may be worth including in your docs. Thanks for the great extension!