Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README updates for Docker #144

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

jasonterando
Copy link

Information on getting Visual Code + PHP Debug extension working with PHP running in Docker. It may be worth including in your docs. Thanks for the great extension!

Information on getting Visual Code + PHP Debug extension working with PHP running in Docker
Copy link
Contributor

@felixfbecker felixfbecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does the diff replace the whole README? Did you change line endings or something like that?

@jasonterando
Copy link
Author

Not on purpose, but very possibly. Let me see if I can de-fubar it...

@seangwright
Copy link

@jasonterando Thanks for the updates here. Even though the PR hasn't been accepted your steps for Windows XDEBUG configuration worked perfectly for me.

@jasonterando
Copy link
Author

@sgwatgit - awesome, glad to help!

@cardonator
Copy link

This also needs to be updated to reflect the changes for the new pathmappings setting.

@codecov
Copy link

codecov bot commented Nov 25, 2017

Codecov Report

Merging #144 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #144   +/-   ##
=======================================
  Coverage   80.18%   80.18%           
=======================================
  Files           2        2           
  Lines         111      111           
  Branches       22       22           
=======================================
  Hits           89       89           
  Misses         14       14           
  Partials        8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfeea18...c65725e. Read the comment docs.

@jasonterando
Copy link
Author

I didn't realize anybody was still looking at this. I've updated to include pathMappings and the built-in Docker localhost aliases.

@felixfbecker
Copy link
Contributor

@jasonterando I think you committed a bad merge

@jasonterando
Copy link
Author

Did a re-merge with master and the CI/CD checks seem to be happier

@felixfbecker
Copy link
Contributor

@smxsm
Copy link

smxsm commented Mar 15, 2018

Too bad this isn't merged yet, very helpful additional info! 👍

Copy link
Contributor

@felixfbecker felixfbecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README is still messed up unfortunately, it duplicates a majority of the content

@felixfbecker felixfbecker changed the base branch from master to main December 21, 2020 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants