Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to xDSL supporting inplace bufferization #59

Merged
merged 13 commits into from
Aug 30, 2024
Merged

Bump to xDSL supporting inplace bufferization #59

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ef1fbf5
Bump to xDSL supporting inplace.
PapyChacal Aug 21, 2024
6e0673c
Litlle dictionary fix?
PapyChacal Aug 21, 2024
b9b1bbc
Flake
PapyChacal Aug 21, 2024
26218f2
Try this dictionary
PapyChacal Aug 21, 2024
9c10636
Merge branch 'emilien/coming-soon' into emilien/inplace
PapyChacal Aug 21, 2024
a2a6922
Sync
PapyChacal Aug 21, 2024
5366f32
Revert more subtle inplace test and present a working one..
PapyChacal Aug 21, 2024
fb54a02
Flake.
PapyChacal Aug 21, 2024
3eafa47
Lift another xfail
PapyChacal Aug 21, 2024
74746f5
Update to PR.
PapyChacal Aug 21, 2024
17f0291
Merge branch 'emilien/coming-soon' into emilien/inplace
PapyChacal Aug 30, 2024
72c909c
Bump to `main`.
PapyChacal Aug 30, 2024
b099001
Merge branch 'master' into emilien/inplace
PapyChacal Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-lit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:

- name: Install requirements and xDSL
run: |
pip install git+https://github.com/xdslproject/xdsl@bd700e9665c040d478a4f3bfa286ede66216b5ed
pip install git+https://github.com/xdslproject/xdsl@c86953132b9bd52b6b9dbbd3463bde52c5c15fda
pip install -e .[tests]

- name: Execute lit tests
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-mlir-mpi-openmp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
run: |
pip install -e .[tests]
pip install mpi4py
pip install git+https://github.com/xdslproject/xdsl@bd700e9665c040d478a4f3bfa286ede66216b5ed
pip install git+https://github.com/xdslproject/xdsl@c86953132b9bd52b6b9dbbd3463bde52c5c15fda

- name: Test with MPI + openmp
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-mlir-mpi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
run: |
pip install -e .[tests]
pip install mpi4py
pip install git+https://github.com/xdslproject/xdsl@bd700e9665c040d478a4f3bfa286ede66216b5ed
pip install git+https://github.com/xdslproject/xdsl@c86953132b9bd52b6b9dbbd3463bde52c5c15fda

- name: Test with MPI - no Openmp
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-mlir-openmp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
run: |
pip install -e .[tests]
pip install mpi4py
pip install git+https://github.com/xdslproject/xdsl@bd700e9665c040d478a4f3bfa286ede66216b5ed
pip install git+https://github.com/xdslproject/xdsl@c86953132b9bd52b6b9dbbd3463bde52c5c15fda

- name: Test no-MPI, Openmp
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-mlir.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
- name: Install requirements and xDSL
run: |
pip install -e .[tests]
pip install git+https://github.com/xdslproject/xdsl@bd700e9665c040d478a4f3bfa286ede66216b5ed
pip install git+https://github.com/xdslproject/xdsl@c86953132b9bd52b6b9dbbd3463bde52c5c15fda

- name: Test no-MPI, no-Openmp
run: |
Expand Down
2 changes: 0 additions & 2 deletions tests/test_xdsl_op_correctness.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,6 @@ def test_symbol_I():
assert type(ops[0] == Return)


# This test should fail, as we are trying to use an inplace operation
@pytest.mark.xfail(reason="Cannot store to a field that is loaded from")
def test_inplace():
# Define a simple Devito Operator
grid = Grid(shape=(3, 3))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to check correct computations here then 🤔

Expand Down
Loading