core: Factor out visibility keyword parsing #2507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moxinilian
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2507 +/- ##
==========================================
+ Coverage 89.78% 89.81% +0.02%
==========================================
Files 350 351 +1
Lines 43284 43615 +331
Branches 6461 6509 +48
==========================================
+ Hits 38863 39172 +309
- Misses 3462 3485 +23
+ Partials 959 958 -1 ☔ View full report in Codecov by Sentry. |
PapyChacal
reviewed
Apr 26, 2024
tests/test_parser.py
Outdated
Comment on lines
873
to
874
| with pytest.raises(ParseError): | ||
| parser.parse_visibility_keyword() |
There was a problem hiding this comment.
Can you add a match= to the pytest.raises()?
It might sound overkill but I find it neat to catch error-reporting regressions, which otherwise are just noticed months later by confused users and are tricky to trace back.
PapyChacal
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR factors out the parsing of visibility keyword into core (like in MLIR) as visibility keywords are a property of the symbol infrastructure. While the symbol lookup in xDSL does not take it into account yet, it is useful to have it be part of the symbol infrastructure itself as those keywords are used in many places (for example, in func.func or hw.module).