Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transforms: stencil-tensorize-z-dim accept stencil.field as function arg #2756

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

n-io
Copy link
Collaborator

@n-io n-io commented Jun 20, 2024

A minor fix (plus test case) that allows the transformation to work on stencil.field passed in as function arguments.

@n-io n-io added minor For minor PRs, easy and quick to review, quickly mergeable transformations Changes or adds a transformatio labels Jun 20, 2024
@n-io n-io requested a review from PapyChacal June 20, 2024 12:17
@n-io n-io self-assigned this Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.80%. Comparing base (f33372f) to head (080c50a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2756   +/-   ##
=======================================
  Coverage   89.80%   89.80%           
=======================================
  Files         372      372           
  Lines       47805    47807    +2     
  Branches     7328     7330    +2     
=======================================
+ Hits        42930    42934    +4     
+ Misses       3737     3736    -1     
+ Partials     1138     1137    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@PapyChacal PapyChacal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay 😀

@n-io
Copy link
Collaborator Author

n-io commented Jun 20, 2024

Yay 😀

As you suggested, this is actually a lot neater (thanks!), but best to allow both since we already support the other.

@n-io n-io merged commit ccbec40 into main Jun 20, 2024
10 checks passed
@n-io n-io deleted the nicolai/tensorise-z-dim-field-fix branch June 20, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor For minor PRs, easy and quick to review, quickly mergeable transformations Changes or adds a transformatio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants