dialects: (riscv) RISCVOp -> RISCVAsmOperation subclass of IRDLOperation #2805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [marimo](https://github.com/marimo-team/marimo) from 0.6.10 to 0.6.23. - [Release notes](https://github.com/marimo-team/marimo/releases) - [Commits](marimo-team/marimo@0.6.10...0.6.23) --- updated-dependencies: - dependency-name: marimo dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
superlopuh
requested review from
nazavode,
compor,
zero9178,
AntonLydike,
JosseVanDelm and
jorendumoulin
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2805 +/- ##
=======================================
Coverage 89.80% 89.80%
=======================================
Files 396 396
Lines 48836 48836
Branches 7480 7480
=======================================
Hits 43857 43857
Misses 3796 3796
Partials 1183 1183 ☔ View full report in Codecov by Sentry. |
nazavode
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't remember why it wasn't always an IRDLOperation, but there's no reason for it not to be one. Also, I took the opportunity to rename into something that both conveys that it's for assembly printing, and abstract (with
Operation) suffix instead of Op.