api: add generic parameter to attribute constraint #2889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
requested review from
AntonLydike,
georgebisbas,
math-fehr,
PapyChacal and
webmiche
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2889 +/- ##
==========================================
+ Coverage 89.85% 89.92% +0.06%
==========================================
Files 399 401 +2
Lines 50171 50340 +169
Branches 7755 7778 +23
==========================================
+ Hits 45083 45266 +183
+ Misses 3860 3847 -13
+ Partials 1228 1227 -1 ☔ View full report in Codecov by Sentry. |
AntonLydike
approved these changes
Jul 16, 2024
Comment on lines
+9
to
+11
| def isattr( | ||
| arg: Any, hint: type[AttributeInvT] | GenericAttrConstraint[AttributeInvT] | ||
| ) -> TypeGuard[AttributeInvT]: |
math-fehr
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 1/2 to make the Pylance errors in operation definitions go away.
The main idea is for the constraint type to carry the upper bound of the Attribute types that will pass verification. It is not guaranteed to be a strict upper bound.
Pyright errors: 489.