Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(dialects): improving stencil attr syntax mlir compatibility #2947

Merged
merged 8 commits into from
Jul 29, 2024

Conversation

n-io
Copy link
Collaborator

@n-io n-io commented Jul 26, 2024

MLIR interoperability needs the (generic) format changed from #stencil.index[0] to #stencil.index<[0]>, and likewise for #stencil.bounds where it also doesn't like the colon.

A practical implication of this is that the syntax of stencil.store has changed, for instance, from
stencil.store %5 to %3 ([0, 0, 0] : [64, 64, 64]) to
stencil.store %5 to %3 (<[0, 0, 0], [64, 64, 64]>)

This PR does not modify the syntax of any ops, and only modified the printing and parsing of the index and bounds attributes. In a future PR, the syntax of the store op (maybe also others) could be reviewed.

@n-io n-io added help wanted Extra attention is needed invalid This doesn't seem right dialects Changes on the dialects labels Jul 26, 2024
@n-io n-io requested review from georgebisbas and PapyChacal July 26, 2024 10:35
@n-io n-io self-assigned this Jul 26, 2024
@n-io n-io marked this pull request as draft July 26, 2024 10:36
@n-io n-io marked this pull request as ready for review July 26, 2024 12:51
@n-io n-io removed the help wanted Extra attention is needed label Jul 26, 2024
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.90%. Comparing base (2d67e7c) to head (d1ec704).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2947   +/-   ##
=======================================
  Coverage   89.90%   89.90%           
=======================================
  Files         407      407           
  Lines       50864    50878   +14     
  Branches     7873     7873           
=======================================
+ Hits        45729    45743   +14     
  Misses       3894     3894           
  Partials     1241     1241           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@PapyChacal PapyChacal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@n-io n-io merged commit 8c5f9a1 into main Jul 29, 2024
9 checks passed
@n-io n-io deleted the nicolai/stencil-mlir-compatibility branch July 29, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants