-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(dialects): improving stencil attr syntax mlir compatibility #2947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2947 +/- ##
=======================================
Coverage 89.90% 89.90%
=======================================
Files 407 407
Lines 50864 50878 +14
Branches 7873 7873
=======================================
+ Hits 45729 45743 +14
Misses 3894 3894
Partials 1241 1241 ☔ View full report in Codecov by Sentry. |
PapyChacal
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MLIR interoperability needs the (generic) format changed from
#stencil.index[0]
to#stencil.index<[0]>
, and likewise for#stencil.bounds
where it also doesn't like the colon.A practical implication of this is that the syntax of
stencil.store
has changed, for instance, fromstencil.store %5 to %3 ([0, 0, 0] : [64, 64, 64])
tostencil.store %5 to %3 (<[0, 0, 0], [64, 64, 64]>)
This PR does not modify the syntax of any ops, and only modified the printing and parsing of the index and bounds attributes. In a future PR, the syntax of the store op (maybe also others) could be reviewed.