dialects: (bufferization) Add to_memref op
#2996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2996 +/- ##
==========================================
- Coverage 89.84% 89.83% -0.02%
==========================================
Files 411 411
Lines 51618 51674 +56
Branches 8021 8033 +12
==========================================
+ Hits 46378 46420 +42
- Misses 3961 3969 +8
- Partials 1279 1285 +6 ☔ View full report in Codecov by Sentry. |
superlopuh
reviewed
Aug 8, 2024
tests/filecheck/mlir-conversion/with-mlir/dialects/bufferization/ops.mlir
Outdated
Show resolved
Hide resolved
superlopuh
reviewed
Aug 8, 2024
superlopuh
reviewed
Aug 9, 2024
tests/filecheck/mlir-conversion/with-mlir/dialects/bufferization/ops.mlir
Outdated
Show resolved
Hide resolved
|
reworked as suggested without depending on constraint variable names |
*Short paragraph summarizing the changes* --- Thank you for submitting a PR to xDSL! Make sure to follow the steps in the checklist below *before* you submit this PR! ## Checklist before you submit this PR: - [ ] If your PR is not ready for review, open it as a draft instead. - [ ] Make sure your PR title follows the [guidelines](https://github.com/xdslproject/xdsl/wiki#commit-and-pr-message-formatting) - [ ] Add some tags to categorize the PR, if able. - [ ] Request review from people you *know* have to sign off on these changes, you can leave it blank for now if you are not sure or don't have the rights to request reviews. - [ ] Tag people you wish to get feedback from (using @\<username>), they will then sort out the reviewers. - [ ] Assign this PR to yourself, if able. - [ ] Delete this checklist and the line above it, only after you've completed all previous tasks. Co-authored-by: Emilien Bauer <bauer.emilien@gmail.com>
This reverts commit 09cd994.
superlopuh
reviewed
Aug 9, 2024
superlopuh
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.