interpreter: use interpreter default bitwidth in run main #3034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarice
reviewed
Aug 14, 2024
| @@ -62,6 +62,7 @@ def register_all_arguments(self, arg_parser: argparse.ArgumentParser): | |||
| arg_parser.add_argument( | |||
| "--index-bitwidth", | |||
| choices=(32, 64), | |||
| default=Interpreter.DEFAULT_BITWIDTH, | |||
There was a problem hiding this comment.
This is defined as the system bitwidth anyway
There was a problem hiding this comment.
Not clear to me what happened before if this wasn't specified
There was a problem hiding this comment.
I added a comment, the argument value is None by default, so it was assigning None explicitly in the init, which was propagated
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3034 +/- ##
==========================================
+ Coverage 90.05% 90.07% +0.01%
==========================================
Files 435 436 +1
Lines 54647 54804 +157
Branches 8473 8510 +37
==========================================
+ Hits 49214 49363 +149
- Misses 4060 4062 +2
- Partials 1373 1379 +6 ☔ View full report in Codecov by Sentry. |
|
I'll look into this and try to determine the difference in behaviour |
alexarice
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.