dialects: (stim) add qubit attribute and qubit coordinate attribute #3114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d files in one folder
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3114 +/- ##
=======================================
Coverage 90.05% 90.06%
=======================================
Files 435 435
Lines 54647 54736 +89
Branches 8473 8490 +17
=======================================
+ Hits 49214 49299 +85
Misses 4060 4060
- Partials 1373 1377 +4 ☔ View full report in Codecov by Sentry. |
superlopuh
reviewed
Aug 29, 2024
superlopuh
reviewed
Aug 29, 2024
superlopuh
reviewed
Aug 29, 2024
superlopuh
reviewed
Aug 29, 2024
superlopuh
reviewed
Aug 29, 2024
superlopuh
reviewed
Aug 29, 2024
Clean up some of the parser implementation ie. use in_angle_brackets Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
superlopuh
approved these changes
Aug 30, 2024
|
Let's merge this? |
emmau678
pushed a commit
that referenced
this pull request
Oct 8, 2024
…3114) Add a base attribute to the stim dialect - StimAttr which is StimPrintable so that all implementing attributes must implement print_stim. Add two initial attributes - QubitAttr to indicate qubits, and QubitCoordAttr which provides a pair of a coordinate of a physical qubit to a QubitAttr --------- Co-authored-by: Emilien Bauer <papychacal@gmail.com> Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a base attribute to the stim dialect - StimAttr which is StimPrintable so that all implementing attributes must implement print_stim.
Add two initial attributes - QubitAttr to indicate qubits, and QubitCoordAttr which provides a pair of a coordinate of a physical qubit to a QubitAttr