Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transformations: Lower csl_wrapper.import to csl.import #3137

Merged
merged 14 commits into from
Sep 4, 2024

Conversation

dk949
Copy link
Collaborator

@dk949 dk949 commented Sep 2, 2024

Hoists the import operation to the top of the csl.module with all of its dependencies. Constructs the struct needed for importing, then imports the module.

@dk949 dk949 added the transformations Changes or adds a transformatio label Sep 2, 2024
@dk949 dk949 requested a review from n-io September 2, 2024 17:32
@dk949 dk949 self-assigned this Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.99%. Comparing base (7e28f5a) to head (8076026).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3137   +/-   ##
=======================================
  Coverage   89.99%   89.99%           
=======================================
  Files         427      427           
  Lines       53798    53834   +36     
  Branches     8332     8339    +7     
=======================================
+ Hits        48413    48449   +36     
+ Misses       4038     4037    -1     
- Partials     1347     1348    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@n-io n-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense for this to be part of the csl-wrapper-to-csl pass?

@dk949
Copy link
Collaborator Author

dk949 commented Sep 3, 2024

Would it make sense for this to be part of the csl-wrapper-to-csl pass?

I thought about it, but figured that that pass is already quite long.

It would simplify the pipeline, so I'm not opposed to combining the passes

@dk949
Copy link
Collaborator Author

dk949 commented Sep 3, 2024

Note

Still need to translate empty field names to concat_structs

@dk949
Copy link
Collaborator Author

dk949 commented Sep 3, 2024

Empty field names handled 👍

(Except that I forgot to fix the test...)

xdsl/dialects/csl/csl_wrapper.py Outdated Show resolved Hide resolved
xdsl/transforms/csl_wrapper_to_csl.py Show resolved Hide resolved
xdsl/transforms/csl_wrapper_to_csl.py Outdated Show resolved Hide resolved
dk949 and others added 3 commits September 3, 2024 13:14
Co-authored-by: Nicolai Stawinoga <36768051+n-io@users.noreply.github.com>
Co-authored-by: Nicolai Stawinoga <36768051+n-io@users.noreply.github.com>
@dk949 dk949 requested a review from n-io September 3, 2024 16:33
@dk949 dk949 merged commit 1559579 into main Sep 4, 2024
14 checks passed
@dk949 dk949 deleted the david/csl-transforms/csl-wrapper-lower-import branch September 4, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
transformations Changes or adds a transformatio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants