-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transformations: Lower csl_wrapper.import
to csl.import
#3137
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3137 +/- ##
=======================================
Coverage 89.99% 89.99%
=======================================
Files 427 427
Lines 53798 53834 +36
Branches 8332 8339 +7
=======================================
+ Hits 48413 48449 +36
+ Misses 4038 4037 -1
- Partials 1347 1348 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense for this to be part of the csl-wrapper-to-csl pass?
I thought about it, but figured that that pass is already quite long. It would simplify the pipeline, so I'm not opposed to combining the passes |
Note Still need to translate empty field names to |
Empty field names handled 👍 (Except that I forgot to fix the test...) |
Co-authored-by: Nicolai Stawinoga <36768051+n-io@users.noreply.github.com>
Co-authored-by: Nicolai Stawinoga <36768051+n-io@users.noreply.github.com>
Hoists the import operation to the top of the
csl.module
with all of its dependencies. Constructs the struct needed for importing, then imports the module.