fix: Minor corrections to the CSL backend #3142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dk949
commented
Sep 4, 2024
dk949
commented
- Fixed missing comma
- Fixed comparison of an attribute with its underlying data
To preserve the correct order of modules being printed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3142 +/- ##
=======================================
Coverage 89.99% 90.00%
=======================================
Files 427 427
Lines 53854 53854
Branches 8343 8343
=======================================
+ Hits 48468 48469 +1
+ Misses 4038 4037 -1
Partials 1348 1348 ☔ View full report in Codecov by Sentry. |
n-io
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.