Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transformations: (csl) add csl.rpc op #3143

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Conversation

dk949
Copy link
Collaborator

@dk949 dk949 commented Sep 4, 2024

When constructing the program module in csl-wrapper-to-csl:

  • find the memcpy/memcpy module
  • get the LAUNCH color from it
  • use it in the csl.rpc op.

When constructing the program module in `csl-wrapper-to-csl`, find the
`memcpy/memcpy` module, get the `LAUNCH` color from it and use it in the
`csl.rpc` op.
@dk949 dk949 added the transformations Changes or adds a transformatio label Sep 4, 2024
@dk949 dk949 requested a review from n-io September 4, 2024 16:35
@dk949 dk949 self-assigned this Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.99%. Comparing base (728c50b) to head (857edb7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3143   +/-   ##
=======================================
  Coverage   89.99%   89.99%           
=======================================
  Files         427      427           
  Lines       53854    53858    +4     
  Branches     8343     8344    +1     
=======================================
+ Hits        48468    48472    +4     
  Misses       4038     4038           
  Partials     1348     1348           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@n-io n-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though it might also go into the pass setting up a csl_wrapper

@dk949
Copy link
Collaborator Author

dk949 commented Sep 5, 2024

LGTM, though it might also go into the pass setting up a csl_wrapper

It could, but this felt like the better place for it, since it's where we fix all the things relating to CSL, like layout and imports.

@dk949 dk949 merged commit 846de73 into main Sep 5, 2024
14 checks passed
@dk949 dk949 deleted the david/csl-transforms/add-rpc branch September 5, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
transformations Changes or adds a transformatio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants