Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend: (csl) Don't use CSL keywords as var names #3152

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

dk949
Copy link
Collaborator

@dk949 dk949 commented Sep 9, 2024

Added a list of CSL language keywords which will be checked along with taken variable names when choosing the name of a new variable.

Added a list of CSL language keywords which will be checked along with
taken variable names when choosing the name of a new variable.
@dk949 dk949 added the backend Compiler backend in xDSL label Sep 9, 2024
@dk949 dk949 self-assigned this Sep 9, 2024
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.00%. Comparing base (62fc437) to head (e73711f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3152   +/-   ##
=======================================
  Coverage   90.00%   90.00%           
=======================================
  Files         427      427           
  Lines       53857    53859    +2     
  Branches     8344     8344           
=======================================
+ Hits        48474    48476    +2     
  Misses       4036     4036           
  Partials     1347     1347           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@AntonLydike AntonLydike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! This was nagging me on the back of my mind for a while!

@dk949 dk949 merged commit 38c18a5 into main Sep 10, 2024
14 checks passed
@dk949 dk949 deleted the david/csl-backen/avoid-csl-keywords branch September 10, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Compiler backend in xDSL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants