Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: various minor fixes for the csl variables #3184

Merged
merged 4 commits into from
Sep 18, 2024

Conversation

dk949
Copy link
Collaborator

@dk949 dk949 commented Sep 17, 2024

  • docstrings
  • verifications
  • get_element_type in VariableOp

These are fixes which should have been in #3183

* docstrings
* verifications
* `get_element_type` in `VariableOp`
@dk949 dk949 added the dialects Changes on the dialects label Sep 17, 2024
@dk949 dk949 requested a review from n-io September 17, 2024 16:03
@dk949 dk949 self-assigned this Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@cd2d585). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3184   +/-   ##
=======================================
  Coverage        ?   90.02%           
=======================================
  Files           ?      431           
  Lines           ?    54267           
  Branches        ?     8406           
=======================================
  Hits            ?    48852           
  Misses          ?     4056           
  Partials        ?     1359           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dk949 dk949 requested a review from n-io September 18, 2024 15:13
@dk949 dk949 merged commit d538fc6 into main Sep 18, 2024
14 checks passed
@dk949 dk949 deleted the david/csl-dialect/csl-variable-fixes branch September 18, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants