Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend: (csl) allow get_dir to be inlined #3202

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

dk949
Copy link
Collaborator

@dk949 dk949 commented Sep 20, 2024

Using _print_or_promote_to_inline_expr instead of print

@dk949 dk949 added minor For minor PRs, easy and quick to review, quickly mergeable backend Compiler backend in xDSL labels Sep 20, 2024
@dk949 dk949 requested a review from n-io September 20, 2024 15:35
@dk949 dk949 self-assigned this Sep 20, 2024
@dk949 dk949 changed the title backend: (csl) allow get_dir to be inlined backend: (csl) allow get_dir to be inlined Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.04%. Comparing base (57c9fa2) to head (0f0ccb1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3202      +/-   ##
==========================================
- Coverage   90.04%   90.04%   -0.01%     
==========================================
  Files         432      432              
  Lines       54455    54454       -1     
  Branches     8448     8448              
==========================================
- Hits        49034    49031       -3     
- Misses       4055     4056       +1     
- Partials     1366     1367       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n-io
Copy link
Collaborator

n-io commented Sep 20, 2024

This may need a small test case.

@dk949 dk949 merged commit 5d9837e into main Sep 23, 2024
14 checks passed
@dk949 dk949 deleted the david/csl-backend/direction-traits branch September 23, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Compiler backend in xDSL minor For minor PRs, easy and quick to review, quickly mergeable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants