Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transformations: (lower-csl-stencil) Store results to apply.dest #3203

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

n-io
Copy link
Collaborator

@n-io n-io commented Sep 20, 2024

Lowering csl_stencil.apply's yield op now stores the results to the dest buffer.

@n-io n-io added minor For minor PRs, easy and quick to review, quickly mergeable transformations Changes or adds a transformatio labels Sep 20, 2024
@n-io n-io self-assigned this Sep 20, 2024
Copy link
Collaborator

@dk949 dk949 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.04%. Comparing base (e9aa7ac) to head (045fbf5).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3203   +/-   ##
=======================================
  Coverage   90.03%   90.04%           
=======================================
  Files         432      432           
  Lines       54437    54455   +18     
  Branches     8443     8448    +5     
=======================================
+ Hits        49014    49034   +20     
+ Misses       4056     4055    -1     
+ Partials     1367     1366    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n-io n-io merged commit 57c9fa2 into main Sep 20, 2024
14 checks passed
@n-io n-io deleted the nicolai/store-results branch September 20, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor For minor PRs, easy and quick to review, quickly mergeable transformations Changes or adds a transformatio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants