Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (cf) branch canonicalization. #3234

Merged
merged 4 commits into from
Oct 2, 2024

Conversation

alexarice
Copy link
Collaborator

Adds one of the canonicalization patterns for cf.branch. The other will need predecessor information for blocks and so is not part of this PR.

@alexarice alexarice added dialects Changes on the dialects testing PRs that modify tests transformations Changes or adds a transformatio labels Oct 2, 2024
@alexarice alexarice self-assigned this Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.06%. Comparing base (4f427e9) to head (f85d198).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3234      +/-   ##
==========================================
- Coverage   90.07%   90.06%   -0.02%     
==========================================
  Files         438      438              
  Lines       54881    54914      +33     
  Branches     8523     8532       +9     
==========================================
+ Hits        49433    49457      +24     
- Misses       4065     4069       +4     
- Partials     1383     1388       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexarice
Copy link
Collaborator Author

Apparently git commit --amend doesn't run precommit...

alexarice and others added 2 commits October 2, 2024 13:32
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
@alexarice alexarice merged commit 7e5543b into main Oct 2, 2024
14 checks passed
@alexarice alexarice deleted the alexarice/branch-canonicalize branch October 2, 2024 12:45
emmau678 pushed a commit that referenced this pull request Oct 8, 2024
Adds one of the canonicalization patterns for `cf.branch`. The other
will need predecessor information for blocks and so is not part of this
PR.

---------

Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects testing PRs that modify tests transformations Changes or adds a transformatio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants