dialects: (llvm) Add support for overflow flags #3269
Conversation
| flags = attributes.pop("overflowFlags") | ||
| if isinstance(flags, OverflowAttr): | ||
| overflowFlags = flags |
There was a problem hiding this comment.
What's MLIR's behaviour here?
There was a problem hiding this comment.
I don't know
And I'm not sure how to check for that
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3269 +/- ##
=======================================
Coverage 89.99% 90.00%
=======================================
Files 445 445
Lines 55749 55801 +52
Branches 5367 5371 +4
=======================================
+ Hits 50173 50225 +52
Misses 4166 4166
Partials 1410 1410 ☔ View full report in Codecov by Sentry. |
|
@tobiasgrosser Are we good to merge? |
Yes |
|
I'm afraid it wasn't ready, the IR doesn't roundtrip, and there are still some questions about printing and parsing the overflow flags when they are specified both in the custom syntax and in the attribute dictionary. I would have appreciated a ping. |
|
Oh sorry, I confused this with the lean-mlir repo. |
|
Reverts are easy. I suggest to revert it and continue the review. |
No description provided.