core: add get_type helper to TypedAttribute #3508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarice
added
minor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3508 +/- ##
==========================================
- Coverage 90.34% 90.34% -0.01%
==========================================
Files 464 464
Lines 58052 58039 -13
Branches 5550 5549 -1
==========================================
- Hits 52448 52436 -12
Misses 4177 4177
+ Partials 1427 1426 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Base automatically changed from
alexarice/typed-attribute-not-generic
to
alexarice/typed-attribute-generic
November 22, 2024 17:13
alexarice
force-pushed
the
alexarice/typed-attribute-generic
branch
from
e0224a8 to
dffa305
Compare
…-attribute-helper
|
This is showing too many changes now in the files changed tab, bit worried to merge it without rebasing (obviously once CI has gone through). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embracing @superlopuh 's school of tiny PRs.
Stacked PR