dialects: (builtin) fix true/false printing #3555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
requested review from
zero9178,
alexarice,
math-fehr,
Moxinilian,
jorendumoulin and
webmiche
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3555 +/- ##
==========================================
- Coverage 90.39% 90.39% -0.01%
==========================================
Files 466 466
Lines 58716 58722 +6
Branches 5592 5593 +1
==========================================
+ Hits 53078 53083 +5
Misses 4204 4204
- Partials 1434 1435 +1 ☔ View full report in Codecov by Sentry. |
alexarice
approved these changes
Dec 2, 2024
| @@ -513,7 +528,7 @@ def parse_with_type( | |||
| return IntegerAttr(parser.parse_integer(allow_boolean=(type == i1)), type) | |||
|
|
|||
| def print_without_type(self, printer: Printer): | |||
| return printer.print(self.value.data) | |||
| self.type.print_value_without_type(self.value.data, printer) | |||
There was a problem hiding this comment.
The polymorphism feels unnecessary to me
There was a problem hiding this comment.
It feels like this could just be
if isinstance(self.type, IntegerAttr) and self.type.bitwidth == 1:
# print bools
...
else:
printer.print_string(str(self.value.data))There was a problem hiding this comment.
I considered it and then felt like doing Python runtime polymorphism is cleaner, if only because we have types like DenseArrayBase, and DenseIntOrFPAttr that will soon have a type and then lots of data, and it seems a little simpler to have the functionality available on the type directly.
superlopuh
force-pushed
the
sasha/builtin/0-bitwidth-ranges
branch
from
fc16538 to
bc68c4c
Compare
superlopuh
force-pushed
the
sasha/builtin/print-i1
branch
from
035fc8a to
061e87c
Compare
EdmundGoodman
pushed a commit
to EdmundGoodman/xdsl
that referenced
this pull request
Dec 6, 2024
We currently don't consistently print true and false for i1 values, this PR fixes that in the cases I could find.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently don't consistently print true and false for i1 values, this PR fixes that in the cases I could find.