-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More refurbishment #4
Conversation
This is an online test, and the value seems to have changed.
Most looks pretty reasonable. I probably had some idea in mind RE: visibility of
Leaving them commented for documentation is good. |
Should be good for another pass. I've also run |
LGTM. Thanks again! |
No problem! Thanks for the fast review and merge. I'll do a third (and final) round for simplifying some of the deserialization traits, and then I'll finally stop 🙂 |
This is my sequel to #3 🙂
Key changes:
pub
by default, preserving interior consistency by marking the structs with#[readonly::make]
use
s to reduce duplicationserde
structs (sinceserde
will simply skip unknown fields)Let me know what you think (especially if you think I went a little too overboard on chasing zero warnings).