Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port Simple Sequence Chain + Unit tests #12

Merged
merged 9 commits into from
May 2, 2023
Merged

Port Simple Sequence Chain + Unit tests #12

merged 9 commits into from
May 2, 2023

Conversation

realdavidvega
Copy link
Contributor

This PR ports SimpleSequentialChain with unit tests, also changes some naming to avoid confusions.

@realdavidvega realdavidvega requested a review from nomisRev April 27, 2023 21:52
@realdavidvega
Copy link
Contributor Author

@franciscodr @nomisRev @gutiory ready to review

@realdavidvega
Copy link
Contributor Author

I have updated the PR applying your suggestions, I have changed the chain's output Boolean to an enum class ChainOutput, and removed the nested either on a fail-fast approach (for simplicity) on SimpleSequentialChain

nomisRev
nomisRev approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @realdavidvega

franciscodr
franciscodr approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@franciscodr franciscodr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @realdavidvega!

@nomisRev nomisRev merged commit c0c170c into main May 2, 2023
@nomisRev nomisRev deleted the sequence-chain branch May 2, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nomisRev nomisRev nomisRev approved these changes

@franciscodr franciscodr franciscodr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@realdavidvega @franciscodr @nomisRev