#861n30d7t: Making OpenAI AutoCloseable and AutoClose #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorcrrd
commented
Jul 20, 2023
openai/src/commonMain/kotlin/com/xebia/functional/xef/auto/llm/openai/OpenAI.kt
Outdated
Show resolved
Hide resolved
victorcrrd
changed the title
victorcrrd
changed the title
Montagon
previously approved these changes
Jul 20, 2023
nomisRev
previously approved these changes
Jul 20, 2023
raulraja
reviewed
Jul 20, 2023
openai/src/commonMain/kotlin/com/xebia/functional/xef/auto/llm/openai/OpenAI.kt
Show resolved
Hide resolved
raulraja
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards better handling the lifetime of classes and the resources they need. In this case, this PR implements the
OpenAIclass (that provides a number of LLM to be easily consumed by users) asAutoCloseableandAutoClose, making sure that allOpenAIClients are closed when we are no longer using the model.