Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static apply method to enable creating RequestConfig from Scala #285

Merged
merged 3 commits into from
Jul 31, 2023

Conversation

sbrunk
Copy link
Contributor

@sbrunk sbrunk commented Jul 28, 2023

With the factory, it should be possible to create RequestConfig instances from Scala and Java.

This seems necessary because User is an inline value class. See #275

I'm not sure if it also makes sense to add a String getter for user.

Copy link
Contributor

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sbrunk !
I took the liberty to merge main back into your branch and apply spotless so the build would pass.

I'm guessing there are more places like this one since we have not yet done a pass to make all the classes and functions compatible for all JVM langs but Kotlin. The same applies to suspend functions which we also plan to address in a better way than what we are doing now wrapping them.

@raulraja raulraja merged commit 042db73 into xebia-functional:main Jul 31, 2023
@raulraja
Copy link
Contributor

this change will be available since 0.0.3-alpha.2

@sbrunk sbrunk deleted the request-config-scala branch July 31, 2023 12:20
@sbrunk
Copy link
Contributor Author

sbrunk commented Jul 31, 2023

Thanks @raulraja! I'll continue playing with it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants