JDBC close Statement and ResultSet #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realdavidvega
added a commit
that referenced
this pull request
May 22, 2023
* Adapt request to token limits + sql module * bail if there is no tokens left after the original prompt * spotlessApply * Use preparedStatement, and close Statement and ResultSet (#83) * Update core/src/commonMain/kotlin/com/xebia/functional/xef/auto/LLMAgent.kt * merge * Token limits in Messages + Improvements (#91) * refactor: reduce complexity and reuse variables * feat: add debug logger on open ai client for token usage * feat: add tokens counting by model * style: spotless happiness * style: more spotless happiness --------- Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com> Co-authored-by: David Vega Lichacz <7826728+realdavidvega@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @raulraja offline, a small PR addressing my review comments on #81.
@xebia-functional/team-ai