ui: Support changing controller/keyboard mappings #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! Good job! Will there be mouse support? |
Mouse support is out of scope for this PR |
antangelo
force-pushed
the
ui/rebinding
branch
from
bd67afa to
a33bec2
Compare
mborgerson
reviewed
Oct 15, 2023
antangelo
force-pushed
the
ui/rebinding
branch
2 times, most recently
from
2df6c52 to
d9a01b2
Compare
|
Can we also have an option to switch the controller image to Controller S? |
antangelo
force-pushed
the
ui/rebinding
branch
2 times, most recently
from
2a055d3 to
35244d8
Compare
|
It is planned to add mapping profiles? That way they can be assigned per-game. |
|
This section takes up a lot of space vertically in the UI. Would it be better to have the grid in a collapsible container? |
|
This could use a rebase, and also, I second that the UI rebind should be a smaller element with a slider that way you can go through it, that's a long boi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a configuration scheme and UI for remapping keyboard/gamepad inputs to the emulated controller. I tried to keep it as modular as possible so that #1478 can extend this system with other devices and the other devices can be mapped independently.
Resolves #136 and supersedes #1301
Leaving in draft initially as this requires some genconfig PRs to be merged-- the genconfig submodule is currently pointed to my fork. I've formatted the PR using clang-format, which is why it differs at points from neighboring code. I am leaving it as-is because formatting code I haven't touched will make this already large change harder to review, but can do so if needed.