Changes for new OVO Create Payment Flow #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewallet.go
Outdated
Comment on lines
16
to
22
| type EWalletXApiVersionEnum string | ||
|
|
||
| // This consists the values that EWalletXApiVersionEnum can take | ||
| const ( | ||
| EWalletXApiVersionEnum20190204 EWalletXApiVersionEnum = "2019-02-04" | ||
| EWalletXApiVersionEnum20200201 EWalletXApiVersionEnum = "2020-02-01" | ||
| ) |
There was a problem hiding this comment.
Let's not have an enum for this as in the ideal case, date-based versioning will be any date within a date range of a version. @slzhffktm Let's accept an arbitrary string for this field
stanleynguyen
approved these changes
Feb 25, 2020
There was a problem hiding this comment.
@slzhffktm Please consider this commit convention for your git usage https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #24
for-user-idheader for Ewallet create payment