-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expanded vec128 and VectorSub #574
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
/** | ||
****************************************************************************** | ||
* Xenia : Xbox 360 Emulator Research Project * | ||
****************************************************************************** | ||
* Copyright 2013 Ben Vanik. All rights reserved. * | ||
* Released under the BSD license - see LICENSE in the root for more details. * | ||
****************************************************************************** | ||
*/ | ||
****************************************************************************** | ||
* Xenia : Xbox 360 Emulator Research Project * | ||
****************************************************************************** | ||
* Copyright 2013 Ben Vanik. All rights reserved. * | ||
* Released under the BSD license - see LICENSE in the root for more details. * | ||
****************************************************************************** | ||
*/ | ||
|
||
#include "xenia/cpu/hir/value.h" | ||
|
||
|
@@ -1007,22 +1007,73 @@ void Value::VectorSub(Value* other, TypeName type, bool is_unsigned, | |
bool saturate) { | ||
assert_true(this->type == VEC128_TYPE && other->type == VEC128_TYPE); | ||
switch (type) { | ||
case FLOAT32_TYPE: | ||
if (saturate) | ||
assert_always(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wrap these one-liner if statements in brackets and you'll be golden! |
||
else { | ||
constant.v128.x -= other->constant.v128.x; | ||
constant.v128.y -= other->constant.v128.y; | ||
constant.v128.z -= other->constant.v128.z; | ||
constant.v128.w -= other->constant.v128.w; | ||
} | ||
break; | ||
case INT32_TYPE: | ||
for (int i = 0; i < 4; i++) { | ||
if (is_unsigned) { | ||
if (saturate) { | ||
assert_always(); | ||
} else { | ||
if (saturate) | ||
assert_always(); | ||
else { | ||
for (int i = 0; i < 4; i++) { | ||
if (is_unsigned) | ||
constant.v128.u32[i] -= other->constant.v128.u32[i]; | ||
} | ||
} else { | ||
if (saturate) { | ||
assert_always(); | ||
} else { | ||
else | ||
constant.v128.i32[i] -= other->constant.v128.i32[i]; | ||
} | ||
} | ||
} | ||
break; | ||
case FLOAT64_TYPE: | ||
if (saturate) | ||
assert_always(); | ||
else { | ||
constant.v128.f64[0] -= other->constant.v128.f64[0]; | ||
constant.v128.f64[1] -= other->constant.v128.f64[1]; | ||
} | ||
break; | ||
case INT8_TYPE: | ||
if (saturate) | ||
assert_always(); | ||
else { | ||
for (int i = 0; i < 16; i++) { | ||
if (is_unsigned) | ||
constant.v128.u8[i] -= other->constant.v128.u8[i]; | ||
else | ||
constant.v128.i8[i] -= other->constant.v128.i8[i]; | ||
} | ||
} | ||
break; | ||
case INT16_TYPE: | ||
if (saturate) | ||
assert_always(); | ||
else { | ||
for (int i = 0; i < 8; i++) { | ||
if (is_unsigned) | ||
constant.v128.u16[i] -= other->constant.v128.u16[i]; | ||
else | ||
constant.v128.i16[i] -= other->constant.v128.i16[i]; | ||
} | ||
} | ||
break; | ||
case INT64_TYPE: | ||
if (saturate) | ||
assert_always(); | ||
else { | ||
if (is_unsigned) { | ||
constant.v128.u64[0] -= other->constant.v128.u64[0]; | ||
constant.v128.u64[1] -= other->constant.v128.u64[1]; | ||
} else { | ||
constant.v128.i64[0] -= other->constant.v128.i64[0]; | ||
constant.v128.i64[1] -= other->constant.v128.i64[1]; | ||
} | ||
} | ||
break; | ||
default: | ||
assert_unhandled_case(type); | ||
break; | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The space needs to come back - just undo this change.