Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded vec128 and VectorSub #574

Merged
merged 2 commits into from
Jun 5, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/xenia/base/vec128.h
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ typedef struct alignas(16) vec128_s {
uint32_t uw;
};
float f32[4];
double f64[2];
int8_t i8[16];
uint8_t u8[16];
int16_t i16[8];
Expand Down
87 changes: 69 additions & 18 deletions src/xenia/cpu/hir/value.cc
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
/**
******************************************************************************
* Xenia : Xbox 360 Emulator Research Project *
******************************************************************************
* Copyright 2013 Ben Vanik. All rights reserved. *
* Released under the BSD license - see LICENSE in the root for more details. *
******************************************************************************
*/
******************************************************************************
* Xenia : Xbox 360 Emulator Research Project *
******************************************************************************
* Copyright 2013 Ben Vanik. All rights reserved. *
* Released under the BSD license - see LICENSE in the root for more details. *
******************************************************************************
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The space needs to come back - just undo this change.


#include "xenia/cpu/hir/value.h"

Expand Down Expand Up @@ -1007,22 +1007,73 @@ void Value::VectorSub(Value* other, TypeName type, bool is_unsigned,
bool saturate) {
assert_true(this->type == VEC128_TYPE && other->type == VEC128_TYPE);
switch (type) {
case FLOAT32_TYPE:
if (saturate)
assert_always();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrap these one-liner if statements in brackets and you'll be golden!

else {
constant.v128.x -= other->constant.v128.x;
constant.v128.y -= other->constant.v128.y;
constant.v128.z -= other->constant.v128.z;
constant.v128.w -= other->constant.v128.w;
}
break;
case INT32_TYPE:
for (int i = 0; i < 4; i++) {
if (is_unsigned) {
if (saturate) {
assert_always();
} else {
if (saturate)
assert_always();
else {
for (int i = 0; i < 4; i++) {
if (is_unsigned)
constant.v128.u32[i] -= other->constant.v128.u32[i];
}
} else {
if (saturate) {
assert_always();
} else {
else
constant.v128.i32[i] -= other->constant.v128.i32[i];
}
}
}
break;
case FLOAT64_TYPE:
if (saturate)
assert_always();
else {
constant.v128.f64[0] -= other->constant.v128.f64[0];
constant.v128.f64[1] -= other->constant.v128.f64[1];
}
break;
case INT8_TYPE:
if (saturate)
assert_always();
else {
for (int i = 0; i < 16; i++) {
if (is_unsigned)
constant.v128.u8[i] -= other->constant.v128.u8[i];
else
constant.v128.i8[i] -= other->constant.v128.i8[i];
}
}
break;
case INT16_TYPE:
if (saturate)
assert_always();
else {
for (int i = 0; i < 8; i++) {
if (is_unsigned)
constant.v128.u16[i] -= other->constant.v128.u16[i];
else
constant.v128.i16[i] -= other->constant.v128.i16[i];
}
}
break;
case INT64_TYPE:
if (saturate)
assert_always();
else {
if (is_unsigned) {
constant.v128.u64[0] -= other->constant.v128.u64[0];
constant.v128.u64[1] -= other->constant.v128.u64[1];
} else {
constant.v128.i64[0] -= other->constant.v128.i64[0];
constant.v128.i64[1] -= other->constant.v128.i64[1];
}
}
break;
default:
assert_unhandled_case(type);
break;
Expand Down