Reset the file path after clear the buffer #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xenodium
requested changes
Aug 27, 2024
| @@ -607,6 +605,13 @@ Set NEW-SESSION to start a separate new session." | |||
| #'chatgpt-shell-prompt-compose) | |||
| shell-buffer)) | |||
|
|
|||
| (defun chatgpt-shell-clear-buffer () | |||
There was a problem hiding this comment.
We should consider moving this to shell-maker since there's nothing chatgpt-shell specific.
xenodium
requested changes
Aug 28, 2024
chatgpt-shell.el
Outdated
| @@ -607,6 +605,13 @@ Set NEW-SESSION to start a separate new session." | |||
| #'chatgpt-shell-prompt-compose) | |||
| shell-buffer)) | |||
|
|
|||
| (defun chatgpt-shell-clear-buffer () | |||
| "Clean the current shell buffer." | |||
There was a problem hiding this comment.
Just give the new commit.
shell-maker.el
Outdated
| @@ -97,6 +97,11 @@ For example: | |||
| :type 'directory | |||
| :group 'shell-maker) | |||
|
|
|||
| (defcustom shell-maker-forget-file-after-clean nil | |||
| "Tell the `shell-maker-save-session-transcript' reset file path or not." | |||
There was a problem hiding this comment.
nit: Consider "If non-nil, reset file path after clear command." as other booleans in this file.
ps. Heads-up, I've just made 54f3166 which is more idiomatic.
xenodium
approved these changes
Aug 28, 2024
ccqpein
changed the title
|
No problem |
xenodium
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to implement the issue #227 .
After
(setf shell-maker-if-file-path-reset-after-clean 'reset)and manually binding the("C-c M-o" . chatgpt-shell-clear-buffer). It will reset theshell-maker--filetonilafter I clean the buffer. So I can save the new conversation in new file.**Feel free to change it if it isn't match the design of owner.