Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore logarithmicDepthBufferEnabled for ortho projection #677

Closed
Amoki opened this issue Jun 25, 2021 · 2 comments
Closed

Ignore logarithmicDepthBufferEnabled for ortho projection #677

Amoki opened this issue Jun 25, 2021 · 2 comments
Assignees
@xeolabs
Labels
bug Something isn't working
Milestone
2.0

Comments

@Amoki
Copy link
Contributor

Amoki commented Jun 25, 2021

Describe the bug
When logarithmicDepthBufferEnabled is true, the ortho project is very glitchy.

To Reproduce
Steps to reproduce the behavior:

  1. set logarithmicDepthBufferEnabled: true
  2. set projection mode to ortho

Expected behavior
Ortho projection work with logarithmicDepthBufferEnabled

Screenshots
Capture d’écran de 2021-06-25 18-38-07
xeolabs added a commit that referenced this issue Sep 6, 2021
@xeolabs
Reproduce log depth bug breakage for ortho #677
207e57c
@xeolabs
Copy link
Member

xeolabs commented Sep 6, 2021

Looking around to see how other WebGL renderers handle this, I noted that THREE actually disables log depth buf for ortho: mrdoob/three.js@8d00c49#diff-5e6741c88cfdbeaa621f557a003c9bd5e3b8e524991e3aebf904422cc2aa0427

@Amoki
Copy link
Contributor Author

Amoki commented Sep 10, 2021

I don't think anyone wants to see a city in ortho mode, it seems to be a good workaround

xeolabs added a commit that referenced this issue Sep 14, 2021
@xeolabs
Disable log depth buff for ortho #677
cfcdeac
@xeolabs xeolabs self-assigned this Sep 14, 2021
@xeolabs xeolabs added the bug Something isn't working label Sep 14, 2021
@xeolabs xeolabs added this to the 2.0 milestone Sep 14, 2021
@xeolabs xeolabs closed this as completed Sep 14, 2021
@xeolabs xeolabs changed the title logarithmicDepthBufferEnabled breaks ortho projection Ignore logarithmicDepthBufferEnabled for ortho projection Sep 14, 2021
xeolabs added a commit that referenced this issue Sep 14, 2021
@xeolabs
Disable log depth buff for ortho #677
9284c0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xeolabs xeolabs

Labels
bug Something isn't working
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@xeolabs @Amoki